fix(ui): replace pod CLI download link with GitHub releases link (#27805)#28264
fix(ui): replace pod CLI download link with GitHub releases link (#27805)#28264KKamJi98 wants to merge 1 commit into
Conversation
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Bundle ReportChanges will increase total bundle size by 153 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: argo-cd-ui-array-pushAssets Changed:
|
KKamJi98
force-pushed
the
fix/help-cli-download-releases
branch
from
2ef700e to
2a506ac
Compare
…oproj#27805) The help page offered a single Linux binary served from the pod, which is the wrong binary for macOS/Windows/arm users and a surprisingly large download. Link to the GitHub releases page for the running version instead. Admins can still expose direct download buttons (internal mirrors, air-gapped) via the existing help.download.<os>-<arch> keys, which can also point at the binary the server serves at download/argocd-linux-<arch>. Signed-off-by: KKamJi <xowl5460@naver.com>
KKamJi98
force-pushed
the
fix/help-cli-download-releases
branch
from
2a506ac to
c11bef9
Compare
KKamJi98
changed the title
kunalworldwide
left a comment
kunalworldwide
left a comment
There was a problem hiding this comment.
Clean PR. A few things I checked:
- Version regex
^v\d+\.\d+\.\d+(-[0-9A-Za-z.]+)?$correctly matches release tags (v3.4.1) and pre-release (v3.4.0-rc1), while sending build metadata versions (+) to the generic releases list. Makes sense since+builds don't have GitHub release tags. - External link correctly uses
target='_blank' rel='noopener noreferrer'. - Backward compat for air-gapped setups preserved —
help.download.<os>-<arch>ConfigMap keys still work, and the server still serves its embedded binary atdownload/argocd-linux-<arch>. - Test coverage is good — covers released versions, RC, dev builds, empty string, and undefined.
- Docs update removes the stale note about duplicate Linux buttons.
LGTM.
blakepettersson
left a comment
blakepettersson
left a comment
There was a problem hiding this comment.
IMO I think a better way to do this would be to set default urls in the argocd-cm (in the kustomize overlays themselves), as described in #28180.
Whether we should do that is a another matter (since this could potentially be considered breaking)
|
That lines up with the follow-up you described in #28180 (config taking precedence over the embedded link). One snag with shipping defaults in argocd-cm: the download URL needs to track the server version, but ConfigMap data isn't version-substituted at release time the way the image tag is (the kustomize An alternative that still gets the precedence behaviour without shipping defaults: render the configured Happy to reshape this PR that way, or go the argocd-cm-defaults route if you'd prefer. Which direction do you want? |
3 participants
The help page offered a single Linux binary served from the pod, which is the wrong binary for macOS, Windows and arm users and a surprise ~200MB download from the cluster.
Per the discussion in the issue, the button now links to the GitHub releases page for the running version instead: straight to the release tag when the server reports one (
v3.4.1,v3.4.0-rc1), or the releases list for dev builds (v3.5.0+0dc5b3f).Admins who want direct download buttons (internal mirrors, air-gapped clusters) can still configure them with the existing
help.download.<os>-<arch>keys, and those can point at the binary the server keeps serving atdownload/argocd-linux-<arch>. Updated the operator docs to match.Closes #27805
Checklist: